kazhnuz/koblog
1
0
Fork 0
Code Issues 22 Pull requests Projects 3 Releases Packages Wiki Activity Actions

Fix #1214 Arbitrary file download vulnerability

Browse source
This commit is contained in:
Anaggh S 2020-06-23 14:22:34 +05:30
parent e3abd64fe4
commit 7689aa5fb4
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
bl-plugins/backup/plugin.php
View file

@ -94,7 +94,10 @@ class pluginBackup extends Plugin {
if (!empty($_GET['file'])) { if (!empty($_GET['file'])) {
$login = new Login(); $login = new Login();
if ($login->role() === 'admin') { if ($login->role() === 'admin') {
downloadRestrictedFile(PATH_WORKSPACES.'backup/'.$_GET['file']); $existingBackups = array_map('basename', glob(PATH_WORKSPACES.'backup/*.zip'));
if (in_array($_GET['file'], $existingBackups)) {
downloadRestrictedFile(PATH_WORKSPACES.'backup/'.$_GET['file']);
}
} else { } else {
Alert::set($L->g('You do not have sufficient permissions')); Alert::set($L->g('You do not have sufficient permissions'));
Redirect::page('dashboard'); Redirect::page('dashboard');