kazhnuz/koblog
1
0
Fork 0
Code Issues 31 Pull requests Projects 3 Releases Packages Wiki Activity Actions

Fix Cross Site Request Forgery on theme selection by using token

Browse source
This commit is contained in:
Alejandro Romero Herrera 2020-08-24 23:15:29 +03:00
parent 916f7b7a16
commit 1b4eeb386a
2 changed files with 18 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
bl-kernel/admin/controllers/install-theme.php
View file

@ -21,10 +21,23 @@ checkRole(array('admin'));
// ============================================================================ // ============================================================================
// Main after POST // Main after POST
// ============================================================================ // ============================================================================
$themeDirectory = $layout['parameters']; $parameters = explode("/", $layout['parameters']);
if(count($parameters)==2) {
$themeDirectory = $parameters[0];
// Activate theme // Verify CSRF Token
activateTheme($themeDirectory); $token = Sanitize::html($parameters[1]);
if (!$security->validateTokenCSRF($token)) {
Log::set(__FILE__.LOG_SEP.'Error occurred when trying to validate the tokenCSRF.', ALERT_STATUS_FAIL);
Log::set(__FILE__.LOG_SEP.'Token in install theme ['.$token.']', ALERT_STATUS_FAIL);
Session::destroy();
Redirect::page('login');
} else {
// Activate theme
activateTheme($themeDirectory);
}
}
// Redirect // Redirect
Redirect::page('themes'); Redirect::page('themes');

4
bl-kernel/admin/views/themes.php
View file

@ -24,7 +24,7 @@ foreach ($themes as $theme) {
'; ';
if ($theme['dirname']!=$site->theme()) { if ($theme['dirname']!=$site->theme()) {
echo '<a href="'.HTML_PATH_ADMIN_ROOT.'install-theme/'.$theme['dirname'].'">'.$L->g('Activate').'</a>'; echo '<a href="'.HTML_PATH_ADMIN_ROOT.'install-theme/'.$theme['dirname'].'/'.$security->getTokenCSRF().'">'.$L->g('Activate').'</a>';
} }
echo ' echo '
@ -50,4 +50,4 @@ foreach ($themes as $theme) {
echo ' echo '
</tbody> </tbody>
</table> </table>
'; ';